Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop depending on libzfs_impl.h, format safety in libzfs #12116

Closed
wants to merge 4 commits into from
Closed

Stop depending on libzfs_impl.h, format safety in libzfs #12116

wants to merge 4 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented May 24, 2021 •
edited
Loading

Motivation and Context

#12048 but defanged

Description

#12048 (comment)

How Has This Been Tested?

Likewise

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand, probably
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli nabijaczleweli mentioned this pull request May 24, 2021
Closed
13 tasks
@amotin
Copy link
Member

amotin commented May 24, 2021

If the idea is to split the commits, why not just update the original PR?

ghost
ghost reviewed May 25, 2021
View reviewed changes
lib/libzfs/os/freebsd/libzfs_zmount.c Outdated Show resolved Hide resolved
include/libzfs.h Outdated Show resolved Hide resolved
@jwk404 jwk404 added the Status: Code Review Needed Ready for review and testing label May 25, 2021
@nabijaczleweli nabijaczleweli force-pushed the what-i-would-do-with-a-palmtop-in-the-privacy-of-my-own-home branch 2 times, most recently from 222d2be to 472ca7a Compare May 25, 2021 18:45
ghost
ghost approved these changes May 25, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

behlendorf
behlendorf requested changes May 26, 2021
View reviewed changes
cmd/zfs/zfs_main.c Outdated Show resolved Hide resolved
@nabijaczleweli nabijaczleweli force-pushed the what-i-would-do-with-a-palmtop-in-the-privacy-of-my-own-home branch from 472ca7a to 2082f48 Compare May 26, 2021 11:03
@nabijaczleweli
libzfs: expose zfs_mount_delegation_check
ea563b3 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli
libzfs: format safety
fc9e44e 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli force-pushed the what-i-would-do-with-a-palmtop-in-the-privacy-of-my-own-home branch from 2082f48 to 858856a Compare May 27, 2021 15:10
@nabijaczleweli
include: move SPA_MINBLOCKSHIFT and zio_encrypt to sys/fs/zfs.h
1733982 
These are used by userspace, so should live in a public header

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli force-pushed the what-i-would-do-with-a-palmtop-in-the-privacy-of-my-own-home branch from 858856a to ccdab15 Compare May 27, 2021 15:11
@nabijaczleweli
libzfs: add zfs_get_underlying_type. Stop including libzfs_impl.h in cmd
feb4e8c 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli force-pushed the what-i-would-do-with-a-palmtop-in-the-privacy-of-my-own-home branch from ccdab15 to feb4e8c Compare May 27, 2021 15:22
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 28, 2021
@adamdmoss
Copy link
Contributor

(mind updating this PR title to something more descriptive?)

@nabijaczleweli nabijaczleweli changed the title Morally inoffensive bits of #12048 Hide libzfs_impl.h, format safety in libzfs May 29, 2021
@nabijaczleweli
Copy link
Contributor Author

done

@nabijaczleweli nabijaczleweli changed the title Hide libzfs_impl.h, format safety in libzfs Stop depending on libzfs_impl.h, format safety in libzfs May 29, 2021
behlendorf pushed a commit that referenced this pull request May 29, 2021
@nabijaczleweli @behlendorf
libzfs: format safety
f00f469 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12116
behlendorf pushed a commit that referenced this pull request May 29, 2021
@nabijaczleweli @behlendorf
include: move SPA_MINBLOCKSHIFT and zio_encrypt to sys/fs/zfs.h
e618e4a 
These are used by userspace, so should live in a public header

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12116
behlendorf pushed a commit that referenced this pull request May 29, 2021
@nabijaczleweli @behlendorf
libzfs: add zfs_get_underlying_type. Stop including libzfs_impl.h in cmd
757df52 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12116
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 10, 2021
@nabijaczleweli @behlendorf
libzfs: format safety
51f5683 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12116
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 10, 2021
@nabijaczleweli @behlendorf
libzfs: format safety
4cf3e48 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12116
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 21, 2022
@nabijaczleweli @tonyhutter
include: move SPA_MINBLOCKSHIFT and zio_encrypt to sys/fs/zfs.h
8e7b4d6 
These are used by userspace, so should live in a public header

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12116
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 22, 2022
@nabijaczleweli @tonyhutter
include: move SPA_MINBLOCKSHIFT and zio_encrypt to sys/fs/zfs.h
faa1e40 
These are used by userspace, so should live in a public header

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

@jwk404 jwk404

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabijaczleweli @amotin @adamdmoss @behlendorf @jwk404